-
-
Notifications
You must be signed in to change notification settings - Fork 904
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for AWS Auth with WebIdentity/OIDC #1112
Conversation
Any movement on this? I am running into an issue related to this. |
@fviard Any chance to get this reviewed ? This tool is used in lot of other cool project (like Gitlab) and this issue prevent us for using the backup feature in EKS. |
@barryib Hi, I will try to review it in the coming days. |
is this PR forgotten ?? it will be great to get this PR merged, s3cmd is used by gitlab task runner and in a EKS environment this is the only serious way to authenticate to backup buckets. |
@samskeyti88 It appears that your branch needs to be rebased against the current master and resolve the conflicts. Maybe doing so will entice the maintainers to consider and move this PR forward. I think that there is a lot of us out here that would like to see this PR merged. |
Any progress on this? |
@fviard It would be really helpful if you could review (& approve) this PR 🥇 |
@ZF-fredericvanlinthoudt I'm sorry that it takes me a little bit of time to enter in this subject, but i'm looking at it and will rebase/merge it soon. |
Would love to see this implemented / merged. It is a really worthwhile feature with security benefits. Anything we can do to help move this across the finish line? |
I have rebased and completed this PR with changes that I have pushed to master. With commits up to d761ead , this feature should now be available. @samskeyti88 Thank you very much for this PR @mosspilot I have pushed things to master, but it is untested, so the best help that you could provide me is to give a try to the MASTER branch and let me know if everything works ok or if you have any issue. Also, the final change now support AssumeRole and AssumeRoleWithWebIdentity. That would be great is someone is able to give a try to the support for AssumeRole also. |
Add support for AWS Auth with WebIdentity/OIDC
#1075